Fix broken build, and inner dev-loop configurations #674
+39
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turned off TreatWarningsAsErrors in VS IDE to speed up inner-dev-loop. - fix settings.json so PaYamlV3 files use the new schema file - Turned some code analysis rules from Error to Warning to improve inner dev-loop
mizrael
approved these changes
Jun 21, 2024
petrochuk
previously requested changes
Jun 21, 2024
tehcrashxor
approved these changes
Jun 21, 2024
swapnilbhalgat
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-fixes issues in the inner dev loop which I'd previously fixed but have been broken again. All of these changes have been fixed at one point, hopefully it'll stick this time.
building locally in VS IDE causes warnings to be treated as Errors. This negatively impacts the inner dev loop experience and causes slower iterative development.
*.pa.yaml files under the PaYamlV3 folders in the repo no longer work with the schemas as they did before.